This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
Change up worker connector semantics slightly #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
jira/no-ticket
jamiebrynes7
force-pushed
the
bugfix/worker-connector-semantics
branch
from
48c6062 to
0ce9259
Compare
improbable-prow-robot
added
A: core
jamiebrynes7
force-pushed
the
bugfix/worker-connector-semantics
branch
from
0ce9259 to
a235270
Compare
paulbalaji
reviewed
May 19, 2020
Co-authored-by: Paul Balaji <[email protected]>
paulbalaji
approved these changes
May 19, 2020
There was a problem hiding this comment.
Will also need a docs change here: https://documentation.improbable.io/gdk-for-unity/docs/blank-project-tutorial-3a-instantiate-a-level
|
Kudos, SonarCloud Quality Gate passed!
|
zeroZshadow
approved these changes
May 19, 2020
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WorkerConnecter.Connectnow throws when it fails to connect. This makes theHandleWorkerConnectionFailedredundant and has been removed. I've also made a couple of behavioural tweaks:WorkerConnectorno longer destroys itself when it fails to connect. Only concern I have here is embedded in the WorkerConnector is this odd disposable MonoBehaviour, I think the reason it destroyed itself was that it was considered "consumed" after a disconnect, but there's no reason why you can't use the same object to connect again! This feels like its tied up in a confused abstraction (where theWorkerConnectoris both a way to connect a worker and something to represent the worker after connection).I expect we will want further work to refine this abstraction (probably related to some of the thoughts that @zeroZshadow had).
Tests
Tested successful & failed worker connections to observe the behaviour.
Documentation