Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

Better gameobject initialization #1333

Merged
merged 13 commits into from
Mar 24, 2020
Merged

Better gameobject initialization #1333

merged 13 commits into from
Mar 24, 2020

Conversation

paulbalaji
Copy link
Contributor

@paulbalaji paulbalaji commented Mar 24, 2020 •
edited
Loading

Description

  • EntityTypeExpectations keeps track of entitytype -> expectedtype[] map
    • ability to define a default type[] as a fallback
  • gameobject initialization system will check if entity has the expected types
    • if it does -> call OnEntityCreated
    • if not, return

Tests

  • playground
  • existing unit tests
  • fps

Documentation

  • changelog
  • upgrade guide
  • readme

Primary reviewers

If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.

Paul Balaji added 4 commits March 24, 2020 14:15
@improbable-prow-robot improbable-prow-robot added the jira/no-ticket Indicates a PR has no corresponding JIRA ticket label Mar 24, 2020
@improbable-prow-robot improbable-prow-robot added the size/L Denotes a PR that changes 150-299 lines, ignoring generated files. label Mar 24, 2020
@improbable-prow-robot improbable-prow-robot added the A: game-object-creation Area: Gameobject creation feature module label Mar 24, 2020
This was referenced Mar 24, 2020
Merged
Closed
zeroZshadow
zeroZshadow approved these changes Mar 24, 2020
View reviewed changes
UPGRADE_GUIDE.md Show resolved Hide resolved
CR
6f64506 
Signed-off-by: Paul Balaji <[email protected]>
jamiebrynes7
jamiebrynes7 approved these changes Mar 24, 2020
View reviewed changes
UPGRADE_GUIDE.md Show resolved Hide resolved
paulbalaji
paulbalaji commented Mar 24, 2020
View reviewed changes
UPGRADE_GUIDE.md Outdated Show resolved Hide resolved
@paulbalaji paulbalaji merged commit 9c0b93f into develop Mar 24, 2020
@paulbalaji paulbalaji deleted the feature/go-init-3 branch March 24, 2020 17:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jamiebrynes7 jamiebrynes7 jamiebrynes7 approved these changes

@zeroZshadow zeroZshadow zeroZshadow approved these changes

@jessicafalk jessicafalk Awaiting requested review from jessicafalk

Assignees
No one assigned
Labels
A: game-object-creation Area: Gameobject creation feature module jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/L Denotes a PR that changes 150-299 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulbalaji @zeroZshadow @jamiebrynes7 @improbable-prow-robot