Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

Entity reservation system #1314

Merged
merged 10 commits into from
Mar 11, 2020
Merged

Conversation

zeroZshadow
Copy link
Contributor

@zeroZshadow zeroZshadow commented Mar 11, 2020

Description

Create an Entity Reservation System.
This system will allow users to obtain reserved entity id's which are backed by an internal pool.
Uses awaitable tasks.

Tests

Unit tests and integrated into Playground cube spawning.

Documentation

  • Changelog

@improbable-prow-robot improbable-prow-robot added jira/no-ticket Indicates a PR has no corresponding JIRA ticket A: core Area: Core GDK A: playground Area: Playground labels Mar 11, 2020
@improbable-prow-robot improbable-prow-robot added the size/L Denotes a PR that changes 150-299 lines, ignoring generated files. label Mar 11, 2020
Copy link
Contributor

@jamiebrynes7 jamiebrynes7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % suggestion

Add GetAsync and TryTake API
Add Changelog
@zeroZshadow zeroZshadow force-pushed the feature/entity-reservation-system branch from f63e7c6 to c7315fc Compare March 11, 2020 16:19
@zeroZshadow zeroZshadow merged commit ff23cc6 into develop Mar 11, 2020
@zeroZshadow zeroZshadow deleted the feature/entity-reservation-system branch March 11, 2020 18:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A: core Area: Core GDK A: playground Area: Playground jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/L Denotes a PR that changes 150-299 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants