This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
Display runtime version in deployment launcher #1302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
jira/no-ticket
jamiebrynes7
force-pushed
the
feature/display-runtime-depl-launcher
branch
from
57381f0 to
8c2f3cb
Compare
paulbalaji
approved these changes
Feb 24, 2020
zeroZshadow
reviewed
Feb 24, 2020
| { | ||
| using (new EditorGUI.DisabledScope(manager.IsActive)) | ||
| { | ||
| var buttonIcon = new GUIContent(EditorGUIUtility.IconContent(BuiltInEditIcon)) |
There was a problem hiding this comment.
Is it making this every frame?
There was a problem hiding this comment.
Hmm good question, to be honest - I cargo-culted this from the other buttons in this window. I can try making them readonly/static and seeing what happens
added 3 commits
February 25, 2020 11:30
moved all style elements to a separate DeploymentLauncherWindowStyle class this class is lazily instantiated in OnGui() this is the same pattern that is used for the BuildConfigurationWindowEditorStyle changed made based on the feedback from @zeroZshadow
jamiebrynes7
force-pushed
the
feature/display-runtime-depl-launcher
branch
from
0fd0704 to
1dee85c
Compare
improbable-prow-robot
added
size/L
zeroZshadow
approved these changes
Feb 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a label which diplays the current runtime version & a button which opens the GDK Tools Configuration window to the deployment launcher.
Tests
Documentation