Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

Golden pinned runtime version #1299

Merged
merged 8 commits into from
Feb 24, 2020
Merged

Golden pinned runtime version #1299

merged 8 commits into from
Feb 24, 2020

Conversation

jamiebrynes7
Copy link
Contributor

@jamiebrynes7 jamiebrynes7 commented Feb 21, 2020 •
edited
Loading

Description

The GDK now has a concept of a golden runtime version which is a pinned version for each GDK version. This is used if the override is not set for local & cloud deployments.

I've also edit the launch script to read from the pinned version or an override via environment variable.

Tests

  • Ran local deployment w/o override
  • Ran local deployment w/ override
  • Ran cloud deployment w/o override
  • Ran cloud deployment w/override
  • Release QA pipeline w/o override
  • Release QA pipeline w/ override

Documentation

  • Changelog

@improbable-prow-robot improbable-prow-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/no-ticket Indicates a PR has no corresponding JIRA ticket labels Feb 21, 2020
@improbable-prow-robot improbable-prow-robot added size/M Denotes a PR that changes 40-149 lines, ignoring generated files. A: maintenance Area: Project maintenance or hygiene A: tooling Area: Tooling labels Feb 21, 2020
@jamiebrynes7 jamiebrynes7 force-pushed the feature/golden-runtime-version branch 2 times, most recently from 889a06d to 572ced4 Compare February 21, 2020 14:27
@jamiebrynes7 jamiebrynes7 force-pushed the feature/golden-runtime-version branch from 572ced4 to ab27953 Compare February 21, 2020 14:41
@jamiebrynes7 jamiebrynes7 marked this pull request as ready for review February 21, 2020 14:56
@improbable-prow-robot improbable-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 21, 2020
paulbalaji
paulbalaji approved these changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@paulbalaji paulbalaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

zeroZshadow
zeroZshadow approved these changes Feb 24, 2020
View reviewed changes
Copy link
Contributor

@zeroZshadow zeroZshadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this technically a breaking change for the deployment launcher? (In case anyone uses it manually)

@jamiebrynes7
Copy link
Contributor Author

Is this technically a breaking change for the deployment launcher? (In case anyone uses it manually)

Yes it is! Good catch

@jamiebrynes7 jamiebrynes7 merged commit d3c1cf8 into develop Feb 24, 2020
@jamiebrynes7 jamiebrynes7 deleted the feature/golden-runtime-version branch February 24, 2020 10:59
This was referenced Feb 24, 2020
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulbalaji paulbalaji paulbalaji approved these changes

@zeroZshadow zeroZshadow zeroZshadow approved these changes

@jessicafalk jessicafalk Awaiting requested review from jessicafalk

Assignees
No one assigned
Labels
A: maintenance Area: Project maintenance or hygiene A: tooling Area: Tooling jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/M Denotes a PR that changes 40-149 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jamiebrynes7 @zeroZshadow @paulbalaji @improbable-prow-robot