This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
[3/5] New CodegenJob model #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
do-not-merge/work-in-progress
zeroZshadow
approved these changes
Feb 12, 2020
...unity/Packages/io.improbable.gdk.tools/.CodeGenTemplate/CodeGenerationLib/Jobs/CodegenJob.cs
Outdated
Show resolved
Hide resolved
...unity/Packages/io.improbable.gdk.tools/.CodeGenTemplate/CodeGenerationLib/Jobs/CodegenJob.cs
Outdated
Show resolved
Hide resolved
Comment on lines
+18
to
+21
| public IEnumerable<string> ExpectedOutputFiles | ||
| => expectedOutputFiles | ||
| .Select(filePath => Path.Combine(OutputDirectory, filePath)) | ||
| .Union(jobTargets.Select(target => target.FilePath)); |
There was a problem hiding this comment.
Why is expectedOutputFiles not already all the expected output files?
There was a problem hiding this comment.
because this information is all inside the jobtargets in the new system
though one could argue we can just add to it each time a job comes in --> consider in cleanup PR
There was a problem hiding this comment.
Is it in the cleanup PR?
...unity/Packages/io.improbable.gdk.tools/.CodeGenTemplate/CodeGenerationLib/Jobs/CodegenJob.cs
Outdated
Show resolved
Hide resolved
...unity/Packages/io.improbable.gdk.tools/.CodeGenTemplate/CodeGenerationLib/Jobs/CodegenJob.cs
Outdated
Show resolved
Hide resolved
...unity/Packages/io.improbable.gdk.tools/.CodeGenTemplate/CodeGenerationLib/Jobs/CodegenJob.cs
Show resolved
Hide resolved
jamiebrynes7
approved these changes
Feb 17, 2020
...unity/Packages/io.improbable.gdk.tools/.CodeGenTemplate/CodeGenerationLib/Jobs/CodegenJob.cs
Outdated
Show resolved
Hide resolved
paulbalaji
force-pushed
the
feature/prep-codegen-generators
branch
from
c45e2cd to
4dc5c8f
Compare
added 7 commits
February 17, 2020 16:00
Signed-off-by: Paul Balaji <[email protected]>
Signed-off-by: Paul Balaji <[email protected]>
Signed-off-by: Paul Balaji <[email protected]>
Signed-off-by: Paul Balaji <[email protected]>
paulbalaji
force-pushed
the
feature/codegen-update
branch
from
dc25cb7 to
5e53f4e
Compare
paulbalaji
changed the base branch from
feature/prep-codegen-generators
to
develop
Signed-off-by: Paul Balaji <[email protected]>
improbable-prow-robot
removed
the
do-not-merge/work-in-progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
JobTargetclass to replace theGenerationTargetsystemJobTargetsystem side-by-side with current systemTests
Documentation
Primary reviewers
If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.