This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
jira/no-ticket
Indicates a PR has no corresponding JIRA ticket
A: core
Area: Core GDK
A: playground
Area: Playground
size/XXL
Denotes a PR that changes 600+ lines, ignoring generated files.
labels
Jan 23, 2020
paulbalaji
reviewed
Jan 23, 2020
...ckages/io.improbable.gdk.core/.codegen/Source/Generators/Core/UnityComponentDataGenerator.cs
Show resolved
Hide resolved
...ckages/io.improbable.gdk.core/.codegen/Source/Generators/Core/UnityComponentDataGenerator.cs
Show resolved
Hide resolved
paulbalaji
reviewed
Jan 23, 2020
...ckages/io.improbable.gdk.core/.codegen/Source/Generators/Core/UnityComponentDataGenerator.cs
Outdated
Show resolved
Hide resolved
...ckages/io.improbable.gdk.core/.codegen/Source/Generators/Core/UnityComponentDataGenerator.cs
Show resolved
Hide resolved
Get dirtybit type size at runtime
paulbalaji
approved these changes
Jan 23, 2020
jamiebrynes7
approved these changes
Jan 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A: core
Area: Core GDK
A: playground
Area: Playground
jira/no-ticket
Indicates a PR has no corresponding JIRA ticket
size/XXL
Denotes a PR that changes 600+ lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simplify dirty bits by used a fixed array of uint's, instead of multiple code generated byte variables.
This change removes the need for switch based logic, and improves alignment of data in SpatialOS components.
Documentation