Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

Port event/viewstorage/provider generators #1249

Merged
merged 3 commits into from
Jan 20, 2020

Conversation

paulbalaji
Copy link
Contributor

Description

ported:

  • event generator
  • reference type provider content
  • reference type provider generator
  • view storage generator

Tests

  • see generated code

Documentation

  • will add changelog in final core port PR

Primary reviewers

If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.

@improbable-prow-robot improbable-prow-robot added the jira/no-ticket Indicates a PR has no corresponding JIRA ticket label Jan 20, 2020
@improbable-prow-robot improbable-prow-robot added size/XXL Denotes a PR that changes 600+ lines, ignoring generated files. A: core Area: Core GDK labels Jan 20, 2020
{
partial.Type("internal static class ReferenceTypeProviders", providers =>
{
foreach (var fieldDetails in componentDetails.FieldDetails)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.Where(f => !f.IsBlittable) ?

@paulbalaji paulbalaji force-pushed the feature/port-core-part-1 branch from 7df6a15 to 1c8e978 Compare January 20, 2020 15:06
@paulbalaji paulbalaji force-pushed the feature/port-core-part-2 branch from 900814e to e550d69 Compare January 20, 2020 16:43
@paulbalaji paulbalaji changed the base branch from feature/port-core-part-1 to develop January 20, 2020 16:43
Signed-off-by: Paul Balaji <[email protected]>
@paulbalaji paulbalaji merged commit 08c0628 into develop Jan 20, 2020
@paulbalaji paulbalaji deleted the feature/port-core-part-2 branch January 20, 2020 16:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A: core Area: Core GDK jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/XXL Denotes a PR that changes 600+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants