-
Notifications
You must be signed in to change notification settings - Fork 77
[UTY-2389] CodeWriter v2: minimum feature set (1/3) #1237
Conversation
Signed-off-by: Paul Balaji <[email protected]>
Signed-off-by: Paul Balaji <[email protected]>
Signed-off-by: Paul Balaji <[email protected]>
Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UTY-2389 |
...o.improbable.gdk.tools/.CodeGenTemplate/CodeGenerationLib/CodeWriter/InitializerCodeBlock.cs
Outdated
Show resolved
Hide resolved
...o.improbable.gdk.tools/.CodeGenTemplate/CodeGenerationLib/CodeWriter/InitializerCodeBlock.cs
Outdated
Show resolved
Hide resolved
....improbable.gdk.tools/.CodeGenTemplate/CodeGenerationLib/CodeWriter/Interfaces/ICodeBlock.cs
Outdated
Show resolved
Hide resolved
...obable.gdk.tools/.CodeGenTemplate/CodeGenerationLib/CodeWriter/Scopes/Abstract/ScopeBlock.cs
Outdated
Show resolved
Hide resolved
...obable.gdk.tools/.CodeGenTemplate/CodeGenerationLib/CodeWriter/Scopes/Abstract/ScopeBlock.cs
Outdated
Show resolved
Hide resolved
...robable.gdk.tools/.CodeGenTemplate/CodeGenerationLib/CodeWriter/Scopes/Abstract/ScopeBody.cs
Outdated
Show resolved
Hide resolved
...robable.gdk.tools/.CodeGenTemplate/CodeGenerationLib/CodeWriter/Scopes/Abstract/ScopeBody.cs
Outdated
Show resolved
Hide resolved
...ble.gdk.tools/.CodeGenTemplate/CodeGenerationLib/CodeWriter/Scopes/Abstract/ScopeBodyList.cs
Show resolved
Hide resolved
...es/io.improbable.gdk.tools/.CodeGenTemplate/CodeGenerationLib/CodeWriter/Scopes/LoopBlock.cs
Show resolved
Hide resolved
...unity/Packages/io.improbable.gdk.tools/.CodeGenTemplate/CodeGenerationLib/CodeWriter/Text.cs
Show resolved
Hide resolved
...es/io.improbable.gdk.tools/.CodeGenTemplate/CodeGenerationLib/CodeWriter/InitializerBlock.cs
Outdated
Show resolved
Hide resolved
...es/io.improbable.gdk.tools/.CodeGenTemplate/CodeGenerationLib/CodeWriter/Scopes/LoopBlock.cs
Show resolved
Hide resolved
...bable.gdk.tools/.CodeGenTemplate/CodeGenerationLib/Model/Details/FieldTypes/ListFieldType.cs
Outdated
Show resolved
Hide resolved
...bable.gdk.tools/.CodeGenTemplate/CodeGenerationLib/Model/Details/FieldTypes/ListFieldType.cs
Outdated
Show resolved
Hide resolved
...robable.gdk.tools/.CodeGenTemplate/CodeGenerationLib/CodeWriter/Scopes/Abstract/ScopeBody.cs
Outdated
Show resolved
Hide resolved
{ | ||
get | ||
{ | ||
if (containedType.FqnType == |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be a lovely switch statement
Lots of blocks create their own |
9997a34
to
6eb3f64
Compare
...es/io.improbable.gdk.tools/.CodeGenTemplate/CodeGenerationLib/CodeWriter/Scopes/LoopBlock.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.tools/.CodeGenTemplate/.editorconfig
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.tools/.CodeGenTemplate/CodeGen.sln.DotSettings
Show resolved
Hide resolved
...bable.gdk.tools/.CodeGenTemplate/CodeGenerationLib/Model/Details/FieldTypes/ListFieldType.cs
Outdated
Show resolved
Hide resolved
...robable.gdk.tools/.CodeGenTemplate/CodeGenerationLib/CodeWriter/Scopes/Abstract/ScopeBody.cs
Show resolved
Hide resolved
...ble.gdk.tools/.CodeGenTemplate/CodeGenerationLib/Model/Details/FieldTypes/OptionFieldType.cs
Show resolved
Hide resolved
Add link to this PR in the changelog then |
Signed-off-by: Paul Balaji <[email protected]>
Signed-off-by: Paul Balaji <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall lgtm, one question regarding loops: seems like the loop block covers foreach
/ for
/ while
, but what about do { .. } while (...)
I didn't find a need for it when porting across our current templates, but it's something that could be added in later should we need it |
Description
The minimum feature set of CodeWriter v2 such that CodeGenerationLib can make full use of it.
Information about the CodeWriter v2 classes
ICodeBlock
ScopeBlock : ICodeBlock
ScopeBody : ScopeBlock
CustomScopeBlock : ScopeBody
LoopBlock : ScopeBody
ScopeBodyList : ICodeBlock
IfElseBlock : ScopeBodyList
TryCatchBlock : ScopeBodyList
InitializerCodeBlock : ICodeBlock
Text : ICodeBlock
TextList : ICodeBlock
Pending work before merging
Tests