Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

Deployment Launcher editor performance improvement #1219

Merged
merged 8 commits into from
Nov 18, 2019
Merged

Deployment Launcher editor performance improvement #1219

merged 8 commits into from
Nov 18, 2019

Conversation

paulbalaji
Copy link
Contributor

@paulbalaji paulbalaji commented Nov 18, 2019 •
edited
Loading

Description

  • stop saving to disk on every change
    • only write unsaved changes if it's been more than 1 second since the last change
    • also write to disk if the window is being closed

Tests

  • feels a lot nicer
  • profile before/after

Documentation

probably worth adding a note in the deployment launcher docs about the save interval

  • changelog

Primary reviewers

If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.

@improbable-prow-robot improbable-prow-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/S Denotes a PR that changes 15-39 lines, ignoring generated files. labels Nov 18, 2019
@paulbalaji paulbalaji marked this pull request as ready for review November 18, 2019 15:08
@improbable-prow-robot improbable-prow-robot added size/M Denotes a PR that changes 40-149 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 15-39 lines, ignoring generated files. labels Nov 18, 2019
jamiebrynes7
jamiebrynes7 reviewed Nov 18, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@improbable-prow-robot improbable-prow-robot added size/S Denotes a PR that changes 15-39 lines, ignoring generated files. and removed size/M Denotes a PR that changes 40-149 lines, ignoring generated files. labels Nov 18, 2019
@paulbalaji paulbalaji merged commit ffab1f5 into develop Nov 18, 2019
@paulbalaji paulbalaji deleted the bugfix/uty2021 branch November 18, 2019 16:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jamiebrynes7 jamiebrynes7 jamiebrynes7 approved these changes

@zeroZshadow zeroZshadow zeroZshadow approved these changes

Assignees
No one assigned
Labels
jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/S Denotes a PR that changes 15-39 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulbalaji @zeroZshadow @jamiebrynes7 @improbable-prow-robot