This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
Choose emulator/device to launch android app on + refactor mobile launcher #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
jira/no-ticket
workers/unity/Packages/io.improbable.gdk.mobile/Editor/AndroidLaunchUtils.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.mobile/Editor/AndroidLaunchUtils.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.mobile/Editor/AndroidLaunchUtils.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.mobile/Editor/AndroidLaunchUtils.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.mobile/Editor/AndroidLaunchUtils.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.mobile/Editor/MobileLauncherWindow.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.mobile/Editor/MobileLauncherWindow.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.mobile/Editor/MobileLauncherWindow.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.mobile/Editor/iOSLaunchUtils.cs
Outdated
Show resolved
Hide resolved
paulbalaji
commented
Oct 16, 2019
workers/unity/Packages/io.improbable.gdk.mobile/Editor/MobileLauncherWindow.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.mobile/Editor/AndroidLaunchUtils.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.mobile/Editor/DeviceLaunchConfig.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.mobile/Editor/MobileLaunchUtils.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.mobile/Editor/MobileLauncherWindow.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.mobile/Editor/DeviceLaunchConfig.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.mobile/Editor/DeviceLaunchConfig.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.mobile/Editor/MobileLauncherWindow.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.mobile/Editor/MobileLauncherWindow.cs
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.mobile/Editor/MobileLauncherWindow.cs
Outdated
Show resolved
Hide resolved
added 2 commits
October 17, 2019 14:33
|
LGTM, can you add a screenshot of the current look in the description? |
zeroZshadow
approved these changes
Oct 18, 2019
jamiebrynes7
approved these changes
Oct 18, 2019
jessicafalk
pushed a commit
that referenced
this pull request
Nov 15, 2019
* When launching worker, create logs directory to prevent the native server launch script failing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MobileLauncherWindowto minimise duplicated codeTests
I've tested all possible emulator/device, local/cloud and android/ios combinations possible on both windows and mac (enumerated below).
Will re-validate this at the end
Documentation
How is this documented (for example: release note, upgrade guide, feature page, in-code documentation)?
Primary reviewers
If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.