Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

Print PlayerConnection port in SpatialOS console #1128

Merged
merged 4 commits into from
Aug 21, 2019

Conversation

jamiebrynes7
Copy link
Contributor

@jamiebrynes7 jamiebrynes7 commented Aug 20, 2019

Description

Adds a feature which sends a log to the SpatialOS console noting which port this worker has open for connecting a remote profiler/etc to.

  • Only runs if we are in a Development build (port isn't available for release builds).
  • Doesn't run for mobile clients.
  • Doesn't run in the editor.

Tested against Linux, MacOS, and Windows.

Remaining work

@improbable-prow-robot
Copy link

Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UTY-2250

1 similar comment
@improbable-prow-robot
Copy link

Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UTY-2250

@improbable-prow-robot improbable-prow-robot added jira/UTY A: core Area: Core GDK size/M Denotes a PR that changes 40-149 lines, ignoring generated files. labels Aug 20, 2019
@jamiebrynes7 jamiebrynes7 merged commit fd9b0f5 into develop Aug 21, 2019
@jamiebrynes7 jamiebrynes7 deleted the feature/UTY-2250-print-debugging-port branch August 21, 2019 09:33
@jamiebrynes7 jamiebrynes7 mentioned this pull request Aug 21, 2019
2 tasks
jessicafalk pushed a commit that referenced this pull request Nov 15, 2019
* Simulated Player Deployment Launcher script (#744)

* Add deployment launcher script

* Improve documentation

* Fix ci dependencies build

* Add /restore flag to msbuild to generate NuGet project.assets.json

* Add /restore flag to msbuild in ci setup

* ci nuget restore

* Add stop command that stops all launched deployments

* Add nuget restore step before build

* Remove nuget start-process in setup-gdk

* Upgrade CI MSBuild version to 15.0

* Fix MSBuild 15 path

* Cleanup unnecessary changes for build

* Upgrade core sdk version to 13.5.1

* Add WorkerCoordinator project

* Update Build and DeploymentLauncher scripts for worker coordinator

* Add WorkerCoordinator setup to Setup.bat

* Update Setup.sh

* Remove start client script argument from coordinator config file

* Update CI to download WorkerCoordinator dependencies

* Tabs to spaces

* Add the option to check for being a simulated player

* Add support for local PIE simulated players

* Improve missing worker coordinator warning

* Remove newlines

* Remove newline

* Refactor authentication

* Refactor worker flags

* Refactor worker connection logic into separate class

* Refactor waiting for clients to exit

* Suppress copy output in Setup.bat

* Launch deployments simultaneously

* Check for launch error for main deployment

* Refactor to use WorldContextObject to get game instance

* Add deployment launcher .bat script

* Add pause to wrapper script - allows you to view output when called from Editor

* Add deployment region options

* Add initial squashed

* Add icons

* Fix validation

* Remove duplicate import

* Fix comments

* Rename boolean vars and update comment

* Fix tooltips

* Fix more tooltips

* Redo todo for deployment launcher list

* Remove newline

* Importing order fix

* Fix more sorting

* Sort import ++

* Some more sorting.

* Minor fix import.

* Spaces to tabs.

* Spaces to tabs.

* Now tabs to spaces :)

* small nit

* Move ordering of ProcessID declarations

* remove cmd.exe

* Update SpatialGDK/Source/SpatialGDKEditor/Private/SpatialGDKEditorCloudLauncher.cpp

Remove brackets

Co-Authored-By: Zomtorg <[email protected]>

* Update SpatialGDK/Source/SpatialGDKEditor/Private/SpatialGDKEditorCloudLauncher.cpp

Remove brackets

Co-Authored-By: Zomtorg <[email protected]>

* Update SpatialGDK/Source/SpatialGDKEditor/Private/SpatialGDKEditorCloudLauncherSettings.cpp

fix spacing

Co-Authored-By: Zomtorg <[email protected]>

* Remove pointer

* Add const

* make function const

* Remove toString

* make pointer const

* Remove state of the validaty of the configuration

* Add the cloud settings to the project settings

* Update SpatialGDK/Source/SpatialGDKEditor/Private/SpatialGDKEditorCloudLauncherSettings.cpp

Fix function call

Co-Authored-By: Zomtorg <[email protected]>

* Move regex to SpatialConstants

* Define deployment launcher absolue path as const in header

* Format

Co-Authored-By: Zomtorg <[email protected]>

* Format

Co-Authored-By: Zomtorg <[email protected]>

* Format

Co-Authored-By: Zomtorg <[email protected]>

* Format

Co-Authored-By: Zomtorg <[email protected]>

* Format

Co-Authored-By: Zomtorg <[email protected]>

* Format

Co-Authored-By: Zomtorg <[email protected]>

* Format

Co-Authored-By: Zomtorg <[email protected]>

* Format

Co-Authored-By: Zomtorg <[email protected]>

* Format

Co-Authored-By: Zomtorg <[email protected]>

* Format

Co-Authored-By: Zomtorg <[email protected]>

* Format

Co-Authored-By: Zomtorg <[email protected]>

* Format

Co-Authored-By: Zomtorg <[email protected]>

* Format

Co-Authored-By: Zomtorg <[email protected]>

* Format

Co-Authored-By: Zomtorg <[email protected]>

* Format

Co-Authored-By: Zomtorg <[email protected]>

* Save config from the popup

* Apply suggestions from code review

Co-Authored-By: Zomtorg <[email protected]>

* Default snapshot and JIRA ticket

* Change header

* Remove expandeable logs and stop deployments button

* Remove simulated player launch config path option

* Change SpatialGDK loading phase to PreDefault, fixes BP func libraries loading issue

* Add deployment region options (#790)

* Auto pick launch config path

* Make simulated player launch config path set from constructor init list

* Multiline

* Add region codes to the deployments

* Remove whitespace

* Static cast

Co-Authored-By: Zomtorg <[email protected]>

* Make function const

Co-Authored-By: Zomtorg <[email protected]>

* Misc changes

* Update SpatialGDK/Source/SpatialGDKEditor/Public/SpatialGDKEditorCloudLauncherSettings.h

Co-Authored-By: Zomtorg <[email protected]>

* Check explicitly to nullptr

Co-Authored-By: Zomtorg <[email protected]>

* Check nullptr explicitly

Co-Authored-By: Zomtorg <[email protected]>

* nullptr explicitly

Co-Authored-By: Zomtorg <[email protected]>

* Remove nullptr check

* Check enum pointer validity

* Fix coordinator auth for worker sdk upgrade

* Include player id in display name

* Make locator hostname and port constants

* Make constant for average delay between client connections

* Improve start delay doc

* Refactor dev auth to use TokenSecret (sdk 13.7)

* Improve missing coordinator warning message

* Remove the SpatialGDKCloudLauncher logger

* Refactor IsSimulatedPlayer to use GameplayStatics

* Remove unused constant

* Braces newline

Co-Authored-By: girayimprobable <[email protected]>

* Add const to argument

Co-Authored-By: girayimprobable <[email protected]>

* Remove linkProtocol argument from simulated player worker

* Remove newline in core-sdk.version

* Add paths

* Remove newline in core-sdk.version

* Fix include not found

* Add const to cpp argument

* Update unreal engine version

* Not use deprecated methods for getting the display names of enums.

* Add the proper SharedPointer header file

* Add missing copyright notices, remove unused imports

* Update imports to be alphabetical

* Update SpatialGDKEditorCloudLauncherSettings.cpp to use FString() rather than TEXT()

Co-Authored-By: Sahil Dhanju <[email protected]>

* Alphabetize imports

* Unbreak

* Fix a cooking error when cloud deployment settings were saved without changing the default region.

* Fix link

* Fix init for sim player config path and add sim player toggle label

* Pause in case of error

* Add comment for return code

* Refactor CloudLauncherSettings to be merged with EditorSettings

* Rename pEnum to Region and change place

* Sort alphabetically classes in EditorToolbar

* Add fade-out and duration to the cloud launch notifications

* Change the DeploymentLauncherAbsolutePath to be part of the editor settings

* Fix SpatialOSDirectory function calls

* Sim player spawn logic refactor  (#1017)

* Refactoring the sim player logic a bit so that the player controller has the right information at spawn time and can automatically spawn a sim player pawn type as opposed to user having to write somewhat hacky logic for it.

* Make Simulated Player Movement Component a first class citizen.

* Fix dllexport

* Update SpatialGDK/Extras/schema/spawner.schema

* Update SpatialGDK/Source/SpatialGDK/Private/Interop/SpatialPlayerSpawner.cpp

* Update SpatialGDK/Source/SpatialGDK/Public/SimulatedPlayers/SimulatedPlayerMovementComponent.h

Co-Authored-By: Wouter Verlaek <[email protected]>

* Update SpatialGDK/Source/SpatialGDK/Private/SimulatedPlayers/SimulatedPlayerMovementComponent.cpp

Co-Authored-By: Wouter Verlaek <[email protected]>

* Remove sim player movement components

* Fix warning due to initializer list ordering.

* Remove auto copying of sim coordinator worker config

* Add new cloud and change to upload

* Bump engine ver

* Fix initializer order

* Update engine ver and deploy menu text

* Fix project Deployment Launcher generation, fix path issues of the launcher and pause after ending

* Remove copying worker coordinator config

* Use GetGDKPlugiNDirectory to get the Deployment Launcher

* Remove unused method

* Shorten deployment launcher path

* Stop running deployments with the same name (#1128)

* Stop running deployments with the same name

* Update worker coordinator path in Build.cs

* Move scripts to standalone exe

* New engine tag

* Add missing include
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A: core Area: Core GDK jira/UTY size/M Denotes a PR that changes 40-149 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants