This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
jira/no-ticket
Indicates a PR has no corresponding JIRA ticket
A: tooling
Area: Tooling
A: transform-synchronization
Area: Transform synchronization feature module
size/XXL
Denotes a PR that changes 600+ lines, ignoring generated files.
labels
Jul 25, 2019
workers/unity/Packages/io.improbable.gdk.querybasedinteresthelper/QueryBasedInterestUtils.cs
Outdated
Show resolved
Hide resolved
...rator/GdkCodeGenerator/Partials/Improbable.Gdk.TransformSynchronization.CompressedQuaternion
Outdated
Show resolved
Hide resolved
vector3d/3f ones
Signed-off-by: Paul Balaji <[email protected]>
Signed-off-by: Paul Balaji <[email protected]>
Signed-off-by: Paul Balaji <[email protected]>
paulbalaji
force-pushed
the
feature/more-type-conversion-methods
branch
from
July 25, 2019 16:41
0539a17
to
0d6115a
Compare
zeroZshadow
suggested changes
Jul 26, 2019
...rator/GdkCodeGenerator/Partials/Improbable.Gdk.TransformSynchronization.CompressedQuaternion
Outdated
Show resolved
Hide resolved
...rator/GdkCodeGenerator/Partials/Improbable.Gdk.TransformSynchronization.CompressedQuaternion
Outdated
Show resolved
Hide resolved
...kages/io.improbable.gdk.tools/.CodeGenerator/GdkCodeGenerator/Partials/Improbable.EdgeLength
Show resolved
Hide resolved
...rator/GdkCodeGenerator/Partials/Improbable.Gdk.TransformSynchronization.CompressedQuaternion
Show resolved
Hide resolved
...rator/GdkCodeGenerator/Partials/Improbable.Gdk.TransformSynchronization.CompressedQuaternion
Outdated
Show resolved
Hide resolved
...rator/GdkCodeGenerator/Partials/Improbable.Gdk.TransformSynchronization.CompressedQuaternion
Outdated
Show resolved
Hide resolved
...rator/GdkCodeGenerator/Partials/Improbable.Gdk.TransformSynchronization.CompressedQuaternion
Show resolved
Hide resolved
Signed-off-by: Paul Balaji <[email protected]>
zeroZshadow
suggested changes
Jul 26, 2019
...rator/GdkCodeGenerator/Partials/Improbable.Gdk.TransformSynchronization.CompressedQuaternion
Outdated
Show resolved
Hide resolved
test-project/Assets/EditmodeTests/Conversions/CoordinatesTests.cs
Outdated
Show resolved
Hide resolved
zeroZshadow
approved these changes
Jul 26, 2019
paulbalaji
force-pushed
the
feature/more-type-conversion-methods
branch
from
July 26, 2019 14:16
8c4ad14
to
3aa0054
Compare
jamiebrynes7
approved these changes
Jul 29, 2019
Merged
jessicafalk
approved these changes
Jul 29, 2019
jessicafalk
pushed a commit
that referenced
this pull request
Nov 15, 2019
…1063) Adds new USpatialStatics blueprint function library with helper functions for SpatialNetworking and Offloading.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A: playground
Area: Playground
A: tooling
Area: Tooling
A: transform-synchronization
Area: Transform synchronization feature module
jira/no-ticket
Indicates a PR has no corresponding JIRA ticket
size/XXL
Denotes a PR that changes 600+ lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
+
,-
,*
,/
forEdgeLength
==
,!=
forEdgeLength
,FixedPointVector3
,CompressedQuaternion
FixedPointVector3
/CompressedQuaternion
implementations to generated codeCoordinates.FromUnityVector(Vector3 v)
Coordinates
EdgeLength.FromUnityVector(Vector3 v)
EdgeLength
FixedPointVector3.FromUnityVector(Vector3 v)
FixedPointVector3
CompressedQuaternion.FromUnityQuaternion(Quaternion q)
CompressedQuaternion
Vector3
.ToCoordinates()
Coordinates
Vector3
.ToFixedPointVector3()
FixedPointVector3
Vector3
.ToEdgeLength()
EdgeLength
FixedPointVector3
.ToUnityVector()
Vector3
FixedPointVector3
.ToCoordinates()
Coordinates
Coordinates
.ToUnityVector()
Vector3
EdgeLength
.ToUnityVector()
Vector3
CompressedQuaternion
.ToUnityQuaternion()
Quaternion
Quaternion
.ToCompressedQuaternion()
CompressedQuaternion
Tests
Documentation
Primary reviewers
If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.