Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

More type conversion methods #1063

Merged
merged 22 commits into from
Jul 29, 2019
Merged

Conversation

paulbalaji
Copy link
Contributor

@paulbalaji paulbalaji commented Jul 25, 2019

Description

  • +, -, *, / for EdgeLength
  • ==, != for EdgeLength, FixedPointVector3, CompressedQuaternion
  • many type conversions
  • moved FixedPointVector3 / CompressedQuaternion implementations to generated code
Static Method Result Type Module Dependency
Coordinates.FromUnityVector(Vector3 v) Coordinates -
EdgeLength.FromUnityVector(Vector3 v) EdgeLength -
FixedPointVector3.FromUnityVector(Vector3 v) FixedPointVector3 Transform Sync
CompressedQuaternion.FromUnityQuaternion(Quaternion q) CompressedQuaternion Transform Sync
Type Method Result Type Module Dependency
Vector3 .ToCoordinates() Coordinates Transform Sync
Vector3 .ToFixedPointVector3() FixedPointVector3 Transform Sync
Vector3 .ToEdgeLength() EdgeLength QBI Helper
FixedPointVector3 .ToUnityVector() Vector3 Transform Sync
FixedPointVector3 .ToCoordinates() Coordinates Transform Sync
Coordinates .ToUnityVector() Vector3 -
EdgeLength .ToUnityVector() Vector3 -
CompressedQuaternion .ToUnityQuaternion() Quaternion Transform Sync
Quaternion .ToCompressedQuaternion() CompressedQuaternion Transform Sync

Tests

  • playground still works
  • actual tests coming soon

Documentation

Primary reviewers

If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.

@improbable-prow-robot improbable-prow-robot added jira/no-ticket Indicates a PR has no corresponding JIRA ticket A: tooling Area: Tooling A: transform-synchronization Area: Transform synchronization feature module size/XXL Denotes a PR that changes 600+ lines, ignoring generated files. labels Jul 25, 2019
@improbable-prow-robot improbable-prow-robot added the A: playground Area: Playground label Jul 25, 2019
CHANGELOG.md Outdated Show resolved Hide resolved
UPGRADE_GUIDE.md Show resolved Hide resolved
UPGRADE_GUIDE.md Outdated Show resolved Hide resolved
UPGRADE_GUIDE.md Outdated Show resolved Hide resolved
UPGRADE_GUIDE.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@paulbalaji paulbalaji force-pushed the feature/more-type-conversion-methods branch from 0539a17 to 0d6115a Compare July 25, 2019 16:41
Paul Balaji added 2 commits July 26, 2019 14:56
@paulbalaji paulbalaji force-pushed the feature/more-type-conversion-methods branch from 8c4ad14 to 3aa0054 Compare July 26, 2019 14:16
@paulbalaji paulbalaji merged commit 94a5ea1 into develop Jul 29, 2019
@paulbalaji paulbalaji deleted the feature/more-type-conversion-methods branch July 29, 2019 13:50
jessicafalk pushed a commit that referenced this pull request Nov 15, 2019
…1063)

Adds new USpatialStatics blueprint function library with helper functions for SpatialNetworking and Offloading.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A: playground Area: Playground A: tooling Area: Tooling A: transform-synchronization Area: Transform synchronization feature module jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/XXL Denotes a PR that changes 600+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants