Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

Release 0.2.5 - Pre-Validation #1046

Merged
merged 1 commit into from
Jul 18, 2019
Merged

Release 0.2.5 - Pre-Validation #1046

merged 1 commit into from
Jul 18, 2019

Conversation

gdk-for-unity-bot
Copy link
Collaborator

@gdk-for-unity-bot gdk-for-unity-bot commented Jul 18, 2019 •
edited by paulbalaji
Loading

Description

  • Package versions
  • Changelog
  • Upgrade guide

Tests

  • Windows
    • local deploy
    • cloud client (Release QA pipeline)
    • editor tooling
  • Mac
    • local deploy
    • cloud client (Release QA pipeline)
    • editor tooling
  • Android
    • local client
    • cloud client
  • iOS
    • local client
    • cloud client

@improbable-prow-robot improbable-prow-robot added jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/M Denotes a PR that changes 40-149 lines, ignoring generated files. A: build-system Area: Build system feature module A: core Area: Core GDK A: game-object-creation Area: Gameobject creation feature module A: mobile Area: Mobile integration A: player-lifecycle Area: Player lifecycle feature module A: tooling Area: Tooling A: transform-synchronization Area: Transform synchronization feature module labels Jul 18, 2019
@gdk-for-unity-bot gdk-for-unity-bot merged commit 6689e30 into spatialos:develop Jul 18, 2019
jessicafalk pushed a commit that referenced this pull request Nov 15, 2019
@aleximprobable
Feature/unr-1267 Ordered RPCs (#1046)
f60b6cb 
* Initial commit

* RPCPayload is now initialized correctly

* Serializing RPCPayload before queueing

* Fixed Peek function call

* Moved RPCContainer to a separate file. More serialization code

* Test implementation of RPC queues on receiving side

* Moved queueing and processing logic to RPCContainer

* Removed RetryIndex from RPCContainer

* Small changes to get the branch ready for merge

* Updated RequireSetup

* Added missing parenthesis

* Removed parenthesis

* Moved GetRPCInfo to NetDriver. Added QueuedRPC pruning

* Some renaming. Fixed RPC packing. Updated TODOs

* Renamed and removed some RPCEndPoint variables

* Improved RPCContainer pruning

* RPC are applied if possible, otherwise queued

* Updated TODO comment

* Fixed a typo that broke RPCContainer::ObjectHasRPCsQueuedOfType function

* Added comments, updated Changelog

* Update SpatialGDK/Source/SpatialGDK/Private/EngineClasses/SpatialNetDriver.cpp

Added newline

Co-Authored-By: Sahil Dhanju <[email protected]>

* Moved GetRPCInfo() to SpatialClassInfoManager, now it returns a copy of FRPCInfo

* Renamed RPCContainer to FRPCContainer. Removed it from SpatialGDK namespaces. Included missing header

* Apply suggestions from code review

Applied Valentyn's suggestions.

Co-Authored-By: improbable-valentyn <[email protected]>

* Fixed a typo

* Moved RPCContainer to Interop

* GetRPCInfo now returns a const ptr. Made HandleRPC param const

* Moved Listening flag to SpatialActorChannel

* Added warning if GetOrCreateSpatialActorChannel fails

* Moved some definitions to the top of RPCContainer

* Changed TQueue to TArray in RPCContainer

* Update SpatialGDK/Source/SpatialGDK/Private/Interop/SpatialClassInfoManager.cpp

Co-Authored-By: Sahil Dhanju <[email protected]>

* Test implementation

* Attempt to fix BK

* Trying to fix BK

* Slight code rearrangement

* If RPC type cannot be found - use Invalid as a placeholder for queueing

* Moved RPCContainer to Utils. Added comments for Endpoint ready flag

* Fixed post-merge issue.

* Increased RequireSetup counter

* Changed FPendingRPCParamsPtr to be UniquePtr

* Added missing consts in RPCContainer

* Created jira tickets for some todos

* GetRPCInfo now returns a const ref. RPCs are not queued without reason

* Updated comments for Endpoint ready flag. Added bCheckRPCOrder jira ticket.

* Removed unusued header, forward declaration

* Made ApplyFunction static

* Removed excessive check, updated warning message

* Updated changelog

* Removed commented code

* Fixed ProcessRPC function
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulbalaji paulbalaji paulbalaji approved these changes

Assignees
No one assigned
Labels
A: build-system Area: Build system feature module A: core Area: Core GDK A: game-object-creation Area: Gameobject creation feature module A: mobile Area: Mobile integration A: player-lifecycle Area: Player lifecycle feature module A: tooling Area: Tooling A: transform-synchronization Area: Transform synchronization feature module jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/M Denotes a PR that changes 40-149 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gdk-for-unity-bot @paulbalaji @improbable-prow-robot