Fix xcode paths #1040
Fix xcode paths #1040
Conversation
improbable-prow-robot
added
jira/no-ticket
Co-Authored-By: Jamie Brynes <[email protected]>
There was a problem hiding this comment.
as mentioned in slack:
Packages/io.improbable.worker.sdk.mobile/BuildPostProcessXCode.cs(5,19): error CS0234: The type or namespace name 'iOS' does not exist in the namespace 'UnityEditor' (are you missing an assembly reference?)
we need an extra check in case people don't have the iOS module installed
| [PostProcessBuild] | ||
| public static void OnPostProcessBuild(BuildTarget buildTarget, string path) | ||
| { | ||
| // Only run for iOS |
There was a problem hiding this comment.
do we need that comment? think that if check is pretty self-explanatory. that's a general comment: some of the comments are good, some of them are not needed like this one or the last one for example
…r-unity into feature/fix-xcode-paths
improbable-prow-robot
added
size/L
workers/unity/Packages/io.improbable.worker.sdk.mobile/BuildPostProcessXCode.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.worker.sdk.mobile/BuildPostProcessXCode.cs
Outdated
Show resolved
Hide resolved
| //pbxType = Type.GetType("UnityEditor.iOS.Xcode.PBXProject"); | ||
| if (pbxType == null) | ||
| { | ||
| Debug.LogWarning("iOS Support not installed."); |
There was a problem hiding this comment.
maybe also tell them what to do when that happens
There was a problem hiding this comment.
Replaced this with an exception as this should only show up when Unity changes their API. The exception will make sure we catch it in buildkite.
| InvokeMethod<string>(xcodeObject, "UpdateBuildPropertyForConfig", configGUID, "LIBRARY_SEARCH_PATHS", | ||
| null, new[] | ||
| { | ||
| "$(SRCROOT)/Libraries/io.improbable.worker.sdk.mobile/Plugins/Improbable/Core/iOS/arm", |
There was a problem hiding this comment.
can we store the string $(SRCROOT)/Libraries/io.improbable.worker.sdk.mobile/Plugins/Improbable/Core/iOS as a field? makes it a bit easier to read
There was a problem hiding this comment.
I rather keep these where they are right now, and it makes their context clear.
There was a problem hiding this comment.
don't think it would make the context less clear, but fine
| InvokeMethod<string>(xcodeObject, "WriteToFile", projPath); | ||
| } | ||
|
|
||
| private static T InvokeStaticMethod<T>(string methodName, params object[] parameters) |
There was a problem hiding this comment.
that could be factored out into something more generic, but doesn't need to happen now
workers/unity/Packages/io.improbable.worker.sdk.mobile/BuildPostProcessXCode.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.worker.sdk.mobile/BuildPostProcessXCode.cs
Outdated
Show resolved
Hide resolved
* RPC tracking (WIP) * Tell server to track RPCs * Add new component to switches * A few modifications, added TODOs * Move RPC tracking to SpatialMetrics * Adjust logs and comments * RequireSetup * Use SendEmptyCommandResponse * Address PR comment * Apply suggestions from code review Remove TODOs for queued RPCs (because queuing logic is going away soon) * Address PR comments
Description
Post process the xcode project library search paths to make sure simulator and arm libraries are separated.