Correctly skip builds which are not marked as required (#1435)

spatialos · Jul 22, 2020 · 91f87ed · 91f87ed
1 parent 6927912
commit 91f87ed
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -19,6 +19,10 @@
 
 - Upgrade to Worker SDK v14.7.0. [#1434](https://github.com/spatialos/gdk-for-unity/pull/1434)
 
+### Fixed
+
+- Build targets which are marked as 'Build', but not 'Required' are now properly skipped if build support is not installed. [#1435](https://github.com/spatialos/gdk-for-unity/pull/1435)
+
 ## `0.3.8` - 2020-07-20
 
 ### Breaking Changes

diff --git a/workers/unity/Packages/io.improbable.gdk.buildsystem/Configuration/BuildContext.cs b/workers/unity/Packages/io.improbable.gdk.buildsystem/Configuration/BuildContext.cs
@@ -58,7 +58,7 @@ public static List<BuildContext> GetBuildContexts(IEnumerable<string> wantedWork
                     Debug.LogWarning(
                         $"Skipping ({targetNames}) because build support is not installed in the Unity Editor and the build target is not marked as 'Required'.");
 
-                    targetConfigs.RemoveAll(t => missingTargets.Contains(t));
+                    supportedTargets.RemoveAll(t => missingTargets.Contains(t));
                 }
 
                 result.AddRange(supportedTargets.Select(targetConfig => new BuildContext