UTY-2646: update dependencies.pinned #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UTY-2646 |
improbable-prow-robot
added
jira/UTY
size/XS
improbable-prow-robot
added
size/S
BryanJY-Wong
requested review from
jamiebrynes7 and
paulbalaji
and removed request for
jamiebrynes7
zeroZshadow
reviewed
Aug 3, 2020
BryanJY-Wong
requested review from
jamiebrynes7,
zeroZshadow,
austinkelmore and
paulbalaji
and removed request for
paulbalaji
jamiebrynes7
reviewed
Aug 4, 2020
| @@ -1,7 +1,7 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFramework>netcoreapp2.1</TargetFramework> | |||
| <TargetFramework>netcoreapp3.1</TargetFramework> | |||
There was a problem hiding this comment.
@zeroZshadow do we want to pin the lang version in all of these too?
There was a problem hiding this comment.
Would be nice. I already saw that some were set to 7.3 and some 7.2
There was a problem hiding this comment.
+1 to pinning lang versions
There was a problem hiding this comment.
Could stay on 7.3? If we need C#8 features we can update as/when needed?
There was a problem hiding this comment.
Equally 8 is fully backwards compatible with 7.3, so its not like choosing 8 has any downsides for us
Co-authored-by: Jamie Brynes <[email protected]>
jamiebrynes7
approved these changes
Aug 5, 2020
paulbalaji
approved these changes
Aug 6, 2020
| @@ -1,7 +1,7 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFramework>netcoreapp2.1</TargetFramework> | |||
| <TargetFramework>netcoreapp3.1</TargetFramework> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uploading macos installer to gcs bucket