Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Legends and Title docs #154

Closed
wants to merge 220 commits into from
Closed

Legends and Title docs #154

wants to merge 220 commits into from

Conversation

bianchi-dy
Copy link
Contributor

@bianchi-dy bianchi-dy commented Feb 19, 2020 •
edited
Loading

This PR:

  • Adds simple Legends and Title documentation to site (i.e. mostly tables of properties and some basic examples)
  • Adds the second-level collapsible Side Nav functionality
  • adds the Florence header to all other pages (it used to apply only to the Home page)

However, I get a 500 error consistently whenever my localhost hot-reloads while I'm on either Title or Legends. Not sure if this is fixed by #130.

Note: title-fix needs to be merged first before this PR, because it contains the usePadding fixes.

@luucvanderzee
fix: row indexing
87a07b4
@luucvanderzee
feat: nested data now actually uses nested DataContainers
d8c0f45
@luucvanderzee
fix: mutarise and summarise of nested DataContainer
d940016
@luucvanderzee
fix: mutarise bug
df12285
@luucvanderzee
feat: refactored transformations to use immer
4c87e39
@luucvanderzee
feat: made initial .transform() call unnecessary
2cb2c1e
@luucvanderzee
fix: do column type check before return column with .column()
f2a11ee
@luucvanderzee
feat: column paths to easily access nested data
c0f17c5
@luucvanderzee
feat: added .mapColumn method
138fd63
@luucvanderzee
refactor: code structure, also added updateRow method
0680be3
@luucvanderzee
fix: switched off warning for categorical single-value domains
0753cdd
@luucvanderzee
_
5712d1b
@luucvanderzee
chore: added jest
31fee8b
@luucvanderzee
test: wrote first dummy test
58afb9e
@luucvanderzee
test: first tests (not working yet)
6d83b9b
@luucvanderzee
_
17cc284
@luucvanderzee
test: managed to set up jest with rollup
e9f0e0d
@luucvanderzee
test: column and row-oriented data loading
c4f945e
@luucvanderzee
test: renamed stuff
92d2545
@luucvanderzee
test: geojson tests
bba112b
@luucvanderzee
test: added test to check that geometries end up in $geometry column
739b11d
@luucvanderzee
chore: changed console.warn to 'warn' utility function
76e3db9
@luucvanderzee
refactor: moved transform mixin
ddc5715
@luucvanderzee
fix: import error
81377dc
@luucvanderzee
test: added data type tests
1c45e21
@luucvanderzee
_
f3bdb90
@luucvanderzee
_
18b484b
@luucvanderzee
refactor: removed some .forEach logic, to improve performance
1e415a7
@luucvanderzee
refactor: removed interval:quantitative and temporal, replaced w/ int…
156e775 
…erval
@luucvanderzee
_
9d4ff2c
luucvanderzee and others added 28 commits March 12, 2020 22:09
@luucvanderzee
fix: FuncLine working again
4616d43
@luucvanderzee
fix: scale invert method typo
4a9a24f
@luucvanderzee
Merge branch 'master' into implement-rendervous
f774049
@atepoorthuis
chore: npm audit fixes
0d9f849
@atepoorthuis
chore: update integration tests
923b8fc
@atepoorthuis
chore: minor linting
41993ec
@atepoorthuis
chore: convert rendervous to dependency
3021b74
@luucvanderzee
Merge branch 'master' of https://github.com/spatialnetworkslab/florence…
49d9d1a 
… into implement-rendervous
@luucvanderzee
chore: removed unused function
f0d662f
@luucvanderzee
Merge branch 'implement-rendervous' of https://github.com/spatialnetw…
91057f6 
…orkslab/florence into implement-rendervous
@bianchi-dy
Merge branch 'master' of https://github.com/spatialnetworkslab/florence…
55e9992 
… into title-fix
@bianchi-dy
Merge branch 'implement-rendervous' of https://github.com/spatialnetw…
b6e5bae 
…orkslab/florence into title-fix
@bianchi-dy
fix: readjust positioning math for title (still missing sense of Grap…
d18fb97 
…hic)
@bianchi-dy
checkpt: refactoring legends and title positioning
8b0d821
@bianchi-dy
Merge branch 'master' of https://github.com/spatialnetworkslab/florence…
5f06df3 
… into guides-docs
@bianchi-dy
feat: turn examples into csb plus ones - with bugs
db8f9a7
@bianchi-dy
fix: minor changes to SideNav styles
bc19ab8
@bianchi-dy
fix: change title math to respect flipY
fe5fa8d
@bianchi-dy
feat: quick fix for gradient legends with flipped section scales
70a0d8a
@bianchi-dy
fix: left with buggy horizontal - flipY and activated flipLabels when…
473e7bd 
… it shouldn't
@bianchi-dy
fix: flipX for discrete legend
4025fb4
@bianchi-dy
fix: flipX for gradient now works
206dbfb
@bianchi-dy
fix: finish quick fix for legends positioning
72d6216
@bianchi-dy
fix: update title
b4665d0
@bianchi-dy
fix: something buggy with merge
f047904
@bianchi-dy
Merge master into branch (very buggy)
74a06a5
@bianchi-dy
Merge branch 'title-fix' of https://github.com/spatialnetworkslab/flo…
6b1a1e8 
…rence into guides-docs
@bianchi-dy
docs: update legend docs but gradient legend is buggy again...
f4e54c6
@bianchi-dy bianchi-dy marked this pull request as ready for review March 18, 2020 06:11
@bianchi-dy bianchi-dy closed this Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bianchi-dy @atepoorthuis @luucvanderzee @GraceGSy @johsi-k