Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-convert SVG images to PDF #319

Merged
merged 3 commits into from
Sep 11, 2019
Merged

Auto-convert SVG images to PDF #319

merged 3 commits into from
Sep 11, 2019

Conversation

mgeier
Copy link
Member

@mgeier mgeier commented Sep 9, 2019

This does not work yet.

For an error log see https://readthedocs.org/projects/nbsphinx/builds/9632595/

@mgeier
Copy link
Member Author

mgeier commented Sep 10, 2019

It turned out that the problem was with a single SVG file:

bad SVG

For some reason, when converted to PDF, this caused troubles.

I've replaced it with a PNG version, and now it seems to work.

@mgeier mgeier marked this pull request as ready for review September 10, 2019 10:26
@mgeier mgeier merged commit e959ff1 into master Sep 11, 2019
@mgeier mgeier deleted the rsvg branch September 11, 2019 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant