Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maplotlib figures do not render #9

Closed
par2 opened this issue Jan 16, 2016 · 6 comments · Fixed by #10
Closed

Maplotlib figures do not render #9

par2 opened this issue Jan 16, 2016 · 6 comments · Fixed by #10

Comments

@par2
Copy link
Contributor

par2 commented Jan 16, 2016

After building, it seems my plots for matplotlib are not rendering. In place of the images are paths to files in the doctrees folder, e.g:

_build%5Cdoctrees%5Cnbsphinx%5Cshowcase_121_1.png

Those images do exist at these paths, but are not being rendered somehow make html. The errors says these files are not readable, which is odd since they are generated from the notebook. Any thoughts?

@par2
Copy link
Contributor Author

par2 commented Jan 16, 2016

UPDATE: It appears the mpl output cells do render on readthedocs. They do not render locally.

@mgeier
Copy link
Member

mgeier commented Jan 16, 2016

This problem only seems to occur on Windows (or it may be related to changes between Sphinx version 1.3.3 and 1.3.4) , see #6.

What OS, what Sphinx version are you using?

@mgeier
Copy link
Member

mgeier commented Jan 16, 2016

I just saw that '%5C' means '\', so I assume it's a Windows problem.
I'm trying to find a way to avoid this ...

mgeier added a commit that referenced this issue Jan 16, 2016
@mgeier
Copy link
Member

mgeier commented Jan 16, 2016

Can you please check if #10 fixes your problem?

@par2
Copy link
Contributor Author

par2 commented Jan 17, 2016

I wasn't sure how to check this properly, but I went ahead and edited nbsphinx.py in site packages. Looks like it resolved the issue. Images now render locally. Thanks. I think you can close this issue.

P.S. This is an awesome extension. I love only having to edit notebooks rather than semi-manually convert, move and delete rst files..

@mgeier
Copy link
Member

mgeier commented Jan 17, 2016

Thanks for testing!

I added an explanation how to properly check out and install different Git branches: https://github.com/spatialaudio/nbsphinx/blob/master/CONTRIBUTING.rst
Please let me know if this is helpful to you.

Thanks for the praise, I'm looking forward to further bug reports and suggestions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants