Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli) : cli compatibility with operator #1793

Merged
merged 6 commits into from
Jul 7, 2022
Merged

feat(cli) : cli compatibility with operator #1793

merged 6 commits into from
Jul 7, 2022

Conversation

soumyadip007
Copy link
Collaborator

@soumyadip007 soumyadip007 commented Jul 6, 2022 •
edited
Loading

Closes / Fixes / Resolves

Explain the feature/fix

  1. deployment service updated
  2. dependency issues resolved
  3. new command added (spaship env)
  4. http & https support added

Does this PR introduce a breaking change

No

Screenshot(s)

View Screenshots

Ready-for-merge Checklist

  • Expected files: all files in this pull request are related to one feature request or issue (no stragglers)?
  • Does the change have appropriate unit tests?
  • Did you update or add any necessary documentation (README.md, WHY.md, etc.)?
  • Was this feature demo'd and the design review approved?

@soumyadip007 soumyadip007 requested a review from hybridx July 6, 2022 04:43
hybridx
hybridx requested changes Jul 6, 2022
View reviewed changes
packages/cli/package.json Outdated Show resolved Hide resolved
packages/cli/src/commands/deploy.js Show resolved Hide resolved
packages/cli/src/commands/env.js Outdated Show resolved Hide resolved
packages/cli/src/commands/init.js Show resolved Hide resolved
packages/cli/src/services/deployService.js Show resolved Hide resolved
@hybridx
Copy link
Member

hybridx commented Jul 6, 2022

Minor changes rest looks good to me @soumyadip007

@soumyadip007 soumyadip007 requested a review from hybridx July 6, 2022 05:46
@soumyadip007
Copy link
Collaborator Author

@hybridx please check

@soumyadip007 soumyadip007 merged commit b1d7716 into spaship:master Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hybridx hybridx hybridx approved these changes

Assignees

@soumyadip007 soumyadip007

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soumyadip007 @hybridx