Add more permutation functionality #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
start buildinng up a test of directly using umfpack's numeric factorization get umfpack factorized components working for case where P==Q and prototype row permutation function add PAQt variation of transform_mat_papt and use it for umfpack test' macroize umfpack tests. remove unfinished permutation function. handle identity permutations add permute_rows and permute_cols use permute_rows and permute_cols to clean up transform_mat_paqt rename transform_mat_paqt to transform_mat_paq add unit tests for transform_mat_paq add tests of permute_rows and permute_cols
jlogan03
force-pushed
the
jlogan/permutations
branch
from
31ce21b
to
a76416b
Compare
mulimoen
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
permute_innerandpermute_outerthat separate the permutation of inner and outer dimensions as found intransform_mat_paptpermute_rowsandpermute_colsthat select eitherpermute_innerorpermute_outerdepending on storagetransform_mat_paqthat mirrorstransform_mat_paptbut allows different permutations for rows and cols and allows nonsquare matricestransform_mat_paqto test umfpack bindings' numeric factorization outputs