CsVec constructors #275
Merged
CsVec constructors #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mulimoen
commented
Jan 25, 2021
vbarrielle
approved these changes
Jan 25, 2021
mulimoen
force-pushed
the
feature/vec_constructors
branch
from
0fcc741 to
6e3888e
Compare
vbarrielle
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the vector analouge to #274
The new API consists of
new: Constructors which panics on failuretry_new: Returns all buffers and the errornew_sorted: A constructors that may sort the indices and datanew_unchecked: Does zero checking of constraintsInternal:
new_trusted: The internal version ofnew_uncheckedA bunch of the other constructors were removed. These can be expressed in some form of the above. The
unsafeview constructors are removed in preference tonew_unchecked, where the caller must ensure valid lifetimesFixes #273