Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configurators to easily set up operators and more #29

Merged
merged 12 commits into from
Jun 19, 2022
Merged

Add configurators to easily set up operators and more #29

merged 12 commits into from
Jun 19, 2022

Conversation

cybersai
Copy link
Member

@cybersai cybersai commented Jun 19, 2022 •
edited
Loading

This PR is built on #28 but addresses a few issues.

  1. Avoid making changes to the config file.
  2. Rename operators to configurators to make it more generic for other use cases.
  3. Remove example operators added.
  4. Update Readme with an example.

@cybersai cybersai requested a review from papamarfo June 19, 2022 11:13
@cybersai cybersai self-assigned this Jun 19, 2022
@cybersai cybersai mentioned this pull request Jun 19, 2022
Merged
@SamuelMwangiW
Copy link
Contributor

I like this implementation better. Thanks @cybersai

@cybersai
Copy link
Member Author

Glad you do @SamuelMwangiW

papamarfo
papamarfo approved these changes Jun 19, 2022
View reviewed changes
Copy link
Member

@papamarfo papamarfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@cybersai cybersai merged commit 7fdb0f5 into main Jun 19, 2022
@papamarfo papamarfo deleted the operators branch June 19, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@papamarfo papamarfo papamarfo approved these changes

Assignees

@cybersai cybersai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cybersai @SamuelMwangiW @papamarfo