-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable dbstat table by default #580
Conversation
Nice! Thank you for opening this. Documentation on Related to #573 which documents Debian has this flag set already. @pawurb Can you please add a small test like the one in https://github.com/sparklemotion/sqlite3-ruby/pull/578/files to exercise the virtual table and prevent regression? The test may fail on some platforms, in which case I'll need the same sort of metadata mentioned in that PR ("is this using the vendored sqlite or a system sqlite?") to conditionally run the test (and I will add that if needed). |
3fae0d3
to
e3dd1e2
Compare
e3dd1e2
to
849253b
Compare
Rebased and added a commit to skip the test when using system libraries (specifically, if the user links against sqlcipher or mswin/mingw sqlite -- see https://github.com/sparklemotion/sqlite3-ruby/actions/runs/11910233460 for the failing tests). |
because system libraries may not have this enabled
849253b
to
b8230f3
Compare
thanks for a quick merge! I've started building https://github.com/pawurb/rails-sqlite-extras so it will help a lot |
😍 that project looks neat! Hoping to ship a release of this today. |
Hi. Similar to TryGhost/node-sqlite3#1279 . This PR enables
dbstat
table, that contains useful info like size of tables, indexes, etc. useful for debugging.