Use a factory method to eliminate "results as hash" check #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Results as hash" should be set on the database, so we should only need to check it once when we first start the query. This patch pulls result set construction in to a factory method on the database object. Doing this eliminates a "translate to hash" check that is performed on every row fetch.
tenderlove
force-pushed
the
stop-checking-hash
branch
from
3d61cfe
to
c1fc1af
Compare
|
Love seeing these small details improvements. I'm learning a fair bit just from reading thru the recent PRs. Looking forward to v2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Results as hash" should be set on the database, so we should only need to check it once when we first start the query. This patch pulls result set construction in to a factory method on the database object. Doing this eliminates a "translate to hash" check that is performed on every row fetch.