extconf.rb: Don't call pkg_config when using bundled libraries #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knu
added a commit
that referenced
this pull request
Jul 2, 2013
…dled_libraries extconf.rb: Don't call pkg_config when using bundled libraries
leejarvis
added a commit
that referenced
this pull request
Jul 2, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes to call
pkg_configonly whenNOKOGIRI_USE_SYSTEM_LIBRARIESspecified,because
pkg_configisn't required when using bundled libraries.And this works as workaround for the bug in 2.0.0-p0, 195, 247: https://bugs.ruby-lang.org/issues/8595
2.0.0-p{0,195,247}'s mkmf modifies
$LDFLAGSafter callingpkg_config. (Already fixed in upstream.. waiting for next release)pkg_config('libxml-2.0')removes-rpaththat added by extconf.rb, so compiled binary will be linked with system's installation.