fix memsize_node when called on xmlAttrs #2924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `properties` field of an `xmlNode` element points to an `xmlAttr`. The first few fields of `xmlAttr` are in common with `xmlNode`, but not the `properties` field which doesn't exist in an `xmlAttr`. The `memsize_node` function was passing an `xmlAttr` to a recursive call and then trying to do the same with the properties of that. This led to type confusion and subsequent crashes. Fixes: sparklemotion#2923
|
cc @peterzhu2118 Can you kick the tires on this when you get a moment? |
|
Thank you for finding the fix so quickly! I can confirm that it no longer crashes with this patch. |
|
I'd really like to have a narrow test case that fails (even if it's just in valgrind). Going to play with this a bit before merging. |
|
OK, inspecting the crash in the debugger shows it's because either there's an Anyway. I added a test that creates a DTD with an attribute just to demonstrate the bug, and prevent the unlikely regression. |
which turns out to be because xmlDTD has "attributes" where xmlNode has "properties"
flavorjones
force-pushed
the
fix-memsize_node
branch
from
db4136a to
4f43e4a
Compare
flavorjones
added a commit
that referenced
this pull request
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
The
propertiesfield of anxmlNodeelement points to anxmlAttr.The first few fields of
xmlAttrare in common withxmlNode, but notthe
propertiesfield which doesn't exist in anxmlAttr.The
memsize_nodefunction was passing anxmlAttrto a recursive calland then trying to do the same with the properties of that.
This led to type confusion and subsequent crashes.
Fixes: #2923
Have you included adequate test coverage?
Yes.
Does this change affect the behavior of either the C or the Java
implementations?
It fixes a crash in the C implementation of an ObjectSpace method that is not implemented in JRuby.