fix: HTML5::Document#url returns the URL passed to the parser #2584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches the behavior of HTML4::Document and XML::Document. Previously this method always returned `nil`. Fixes #2583
jgarber623
approved these changes
Jun 23, 2022
There was a problem hiding this comment.
Tested locally with the same script outlined in #2583 (but with the gem source pointing at this PR's branch) and everything works as expected!
$ ruby test.rb
Testing Nokogiri::HTML...
https://hello.example
Testing Nokogiri::HTML4...
https://hello.example
Testing Nokogiri::HTML5...
https://hello.exampleThanks for the quick fix! 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Closes #2583
HTML5::Document#url now matches the behavior of HTML4::Document and XML::Document. Previously this method always returned
nil.I've also improved the documentation for HTML5::Document.
Have you included adequate test coverage?
Yes!
Does this change affect the behavior of either the C or the Java implementations?
This affects the behavior of HTML5::Document which only exists in the C implementation today.