Switch to upstream html5lib-tests #2287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not completely sure I correctly updated the submodule. Hopefully the CI run will make it clear which commit from which repo the submodule was checked out. No, that was the wrong commit. This time it looks fine. |
My PR to fix the errors html5lib/html5lib-tests#136 was merged. We can now track the upstream repository. Closes #2282
|
@stevecheckoway Would it be useful to have a job in the "upstream" CI pipeline to run tests against the latest head of That pipeline runs a few times a week on a timer to give us some advanced notice if upstream changes are causing test failures. If that seems useful, I'm happy to add the job to this PR or create a separate one, whichever you'd prefer. |
|
Ah, I'm going to merge this and we can chat about an upstream job in a new PR. |
|
Such an upstream job sounds like a fantastic idea! |
|
See #2288 for upstream PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My PR to fix the errors
html5lib/html5lib-tests#136 was merged. We can
now track the upstream repository.
Closes #2282
What problem is this PR intended to solve?
The html5 tests had been tracking my fork of html5lib-tests but with html5lib/html5lib-tests#136 merged, we can track upstream. #2282
Have you included adequate test coverage?
There is no change in test coverage.
Does this change affect the behavior of either the C or the Java implementations?
This is only relevant to the C implementation, but it affects the behavior of neither.