Free all unlinked nodes #1791
Closed
Free all unlinked nodes #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay, I don't understand the namespace handling but perhaps something else owns the href and prefix strings? |
DTD nodes added to a document are not freed when the document is freed. Fixes #1784
|
Whelp, I have absolutely no idea what the issue here is then. The Valgrind invalid reads don't seem related to my change. |
|
I'll take a look when I get a chance. |
|
@stevecheckoway If you close and reopen this PR you should kick off another build which will (properly) ignore those valgrind errors. See ec52483 for context. No need to rebase. |
|
Oh - but please rebase to get the JRuby test failures to pass. If you do that in the next day or two, I'll merge into the next release (or if I have time I'll do it myself). Thanks! |
|
I've rebased and pushed to a new branch under #1825. Please follow along there! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nodes that have been relinked should not be freed since they will be
freed when their owning document is freed. Every other node can be freed
directly.
Previously, unlinked DTD nodes were leaked because
xmlFreeNodeListdoes not act on DTD nodes. Separately, the
hrefandprefixmembersof
xmlNsnodes (those of typeXML_NAMESPACE_DECL) were also beingleaked.
Fixes #1784