Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish patched NekoDTD to Maven Central #2437

Closed
5 tasks done
flavorjones opened this issue Jan 26, 2022 · 7 comments · Fixed by #2538
Closed
5 tasks done

publish patched NekoDTD to Maven Central #2437

flavorjones opened this issue Jan 26, 2022 · 7 comments · Fixed by #2538

Comments

@flavorjones
Copy link
Member

flavorjones commented Jan 26, 2022

Problem summary

Currently Nokogiri's java native gem depends on patched versions of NekoDTD and NekoHTML. The binary artifacts only exist in Nokogiri's git repo and if I needed to reproduce them I would be starting from scratch.

Historical context

In the past (e.g., 2e5ce32 in 2012 and 6166964 in 2015) we've patched NekoHTML and NekoDTD to fix bugs or parsing errors. These repositories live (I think) at:

A conversation at #1253 suggested using jar-dependencies to manage Java dependencies, and #2432 starting doing so for the artifacts listed on Maven Central.

What do we want to do

This issue is intended to drive a conversation with the following potential outcomes:

Doing all of the above would allow us to consider further patches on the Neko libraries, e.g., #2436.

cc @jvshahid whose support and assistance I will need

@flavorjones
Copy link
Member Author

@jvshahid Would you be open to transferring ownership of those repositories to me or to the sparklemotion org? That would unblock me to do the rest of the work.

@flavorjones
Copy link
Member Author

Thanks, @jvshahid! Repositories have been transferred to @sparklemotion/nokogiri-core

@flavorjones
Copy link
Member Author

I've created a JIRA account at OSSRH and requested a new project with the groupId org.nokogiri: https://issues.sonatype.org/browse/OSSRH-77736

@headius
Copy link
Contributor

headius commented Feb 1, 2022

@flavorjones As always let me know if I can help. I get a lot of notifications so I don't always see updates here, but I support this move and will try to help as time permits.

@flavorjones
Copy link
Member Author

@headius Thanks for checking in! I will be respectful of your time, but may ask for advice or a code review here and there as I work through this and a handful of other JRuby issues for v1.14.0.

@flavorjones flavorjones changed the title publish patched NekoDTD and NekoHTML to Maven Central publish patched NekoDTD to Maven Central May 10, 2022
@flavorjones
Copy link
Member Author

Note that on main, we get our HTML parser from neko-htmlunit and not the fork of nekohtml mentioned above. I've updated the title and description to reflect that we don't need to do that work anymore.

@flavorjones
Copy link
Member Author

flavorjones commented May 10, 2022

See #2538 and sparklemotion/nekodtd#1. This is basically done, just waiting for CI to go green.

flavorjones added a commit that referenced this issue May 11, 2022
…odtd-via-maven

dep: pull nekodtd from maven

---

**What problem is this PR intended to solve?**

Closes #2437 

See sparklemotion/nekodtd#1 for full context, this completes the process of migrating to maven-managed dependencies for JRuby.

This PR pulls org.nokogiri:nekodtd from maven central.


**Have you included adequate test coverage?**

No behavioral change, existing tests are fine.


**Does this change affect the behavior of either the C or the Java implementations?**

No behavioral change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants