fix(jruby): XML::DocumentFragment.dup to another document (v1.17.x) (#…

…3373) Backport of #3372
sparklemotion · Dec 12, 2024 · ffaa44c · ffaa44c
2 parents e4bae8a + 8bd6c6d
commit ffaa44c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/ext/java/nokogiri/XmlNode.java b/ext/java/nokogiri/XmlNode.java
@@ -978,10 +978,11 @@ public class XmlNode extends RubyObject
 
   @JRubyMethod(visibility = Visibility.PROTECTED)
   public IRubyObject
-  initialize_copy_with_args(ThreadContext context, IRubyObject other, IRubyObject level, IRubyObject _ignored)
+  initialize_copy_with_args(ThreadContext context, IRubyObject other, IRubyObject level, IRubyObject document)
   {
     boolean deep = level instanceof RubyInteger && RubyFixnum.fix2int(level) != 0;
     this.node = asXmlNode(context, other).node.cloneNode(deep);
+    setDocument(context, (XmlDocument)document);
     return this;
   }
 

diff --git a/test/xml/test_node.rb b/test/xml/test_node.rb
@@ -238,8 +238,6 @@ def test_dup_same_parent_document_is_default
         end
 
         def test_dup_different_parent_document
-          skip_unless_libxml2("Node.dup with new_parent arg is only implemented on CRuby")
-
           doc1 = XML::Document.parse("<root><div><p>hello</p></div></root>")
           doc2 = XML::Document.parse("<div></div>")