-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quotes are being stripped out of the cookie values #11
Comments
I looked a bit into this and I wonder if the parser should keep track of the raw value to be able to return the values quoted when they have been parsed quoted. |
We keep track of the original quoted value when it is already quoted, and we avoid consider values to be quoted if they start with a quote.
I've not attempted executing this fix, but the concept sounds like a good idea. |
Hello @knu, @uksa, @lacostej , @serialbandicoot But im just wondering will this issue be fixed, or its not an issue at all. Here is what i see in headers:
But here its not quoted. (i'm using Mechanize agent)
when i expected it to be Another strange issue.. if i manually change value to quoted one and trying to call .to_s ...
Shouldn't it bee |
It's been a really long time since I've needed to look at this issue, however I did remember that depending on the Ruby version you used, also affected how this issue was manifesting. Hence the reason for failing tests in the original comment. Sorry I can't be any more help!... |
I've had an issue, when a cookie contains quotes wrapped around the value, the library is stripping out the quotes. Which is causing my authentication to fail. I've created a monkey in my fork, however when I went to create the tests and submit. It seems there is a few failing tests in this area and a bit more complex than I original thought.
scanner.rb
Before
After:
I'll try and get to the bottom of the failing tests, I'm running Ruby 2.1.3
Perhaps it would be worth adding the tests into Travis. Would be more than happy to update if desired?
The text was updated successfully, but these errors were encountered: