Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wire
now seems to require methodbegin()
to be called beforebeginTransmission()
. This patch accomodates such new requirement by executing_i2cPort->begin();
ifWire
is used.Tested on Lolin32, and can confirm it works now with the fix. Not sure if this change should be specifically applied for ESP32, or can be generalized to non-TEENSY3_I2C implementations.
Error message
Related links
https://community.platformio.org/t/updating-espressif-32-to-5-2-0-breaks-wire-cpp/30282/2
espressif/arduino-esp32@9bceb28
https://github.com/espressif/arduino-esp32/blob/master/libraries/Wire/src/Wire.cpp#L278-L308