Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USB serial number descriptor should report device ID in lower case (0.7.x) #1436

Merged

Conversation

sergeuz
Copy link
Member

@sergeuz sergeuz commented Nov 20, 2017

Problem

Fixes https://github.com/spark/firmware/issues/1432.

Note: There's no need to increment the bootloader version, since it has already been done in #1433.

Steps to Test

Ensure that the USB serial descriptor reports the device ID in all lower case in both the regular and DFU device modes.

References

  • [CH9628]

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@m-mcgowan m-mcgowan merged commit e914096 into release/v0.7.0-rc.5 Nov 20, 2017
@technobly technobly deleted the fix/usb_descr_device_id_lower_case_0.7.x branch March 14, 2018 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants