Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USB serial number descriptor should report device ID in lower case (0.8.x) #1437

Merged
merged 1 commit into from
Nov 20, 2017

Conversation

sergeuz
Copy link
Member

@sergeuz sergeuz commented Nov 20, 2017

Problem

Fixes https://github.com/spark/firmware/issues/1432.

Steps to Test

Ensure that the USB serial descriptor reports the device ID in all lower case in both the regular and DFU device modes.

References


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@sergeuz sergeuz added the bug label Nov 20, 2017
@sergeuz sergeuz added this to the 0.8.0 milestone Nov 20, 2017
@m-mcgowan
Copy link
Contributor

I already merged 0.7.0-rc.5 into develop, and consequently #1436 was already merged, so no need to merge this.

@m-mcgowan m-mcgowan merged commit 6a49e8a into develop Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Device ID reported by DFU is capitalized
2 participants