Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for RGB.onChange() handler leak #1352

Merged
merged 1 commit into from
Jul 10, 2017
Merged

Test for RGB.onChange() handler leak #1352

merged 1 commit into from
Jul 10, 2017

Conversation

sergeuz
Copy link
Member

@sergeuz sergeuz commented Jul 9, 2017 •
edited by technobly
Loading

This PR adds a test for RGB.onChange() handler leak which was fixed in #1237

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation (N/A)
  • Added to CHANGELOG.md after merging (add links to docs and issues)

Internal

  • [PR #1352] Added test for RGB.onChange() handler leak

@sergeuz sergeuz added this to the 0.7.0 milestone Jul 9, 2017
@sergeuz sergeuz requested a review from technobly July 9, 2017 09:15
@technobly technobly merged commit af9f76e into develop Jul 10, 2017
@technobly technobly deleted the fix/rgb_on_change_test branch July 10, 2017 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@technobly technobly technobly approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sergeuz @technobly