Rename system_error to system_error_t #1326
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
C++11 defines
std::system_error
class which may cause global name conflicts with the firmware'ssystem_error
enum, especially in applications that abuseusing namespace std
.Solution
Rename
system_error
enum tosystem_error_t
. We never exposedsystem_error
as part of any public API, so the fix won't affect existing applications.Steps to Test
The firmware and unit tests should build normally.
Example App
N/A
References
Original community post: https://community.particle.io/t/compile-error-gcc-arm-on-linux-firmware-v-0-6-1/31157
Completeness
Bugfix
[PR #1326]
Renamedsystem_error
enum tosystem_error_t
to avoid conflicts withstd::system_error
class.