Fix LED indication when clearing network credentials #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The LED doesn't blink rapidly when clearing network credentials.
Note: This regression doesn't present in any of the releases, so there's no need to update the change log.
Solution
Use higher priority for the LED indication.
Steps to Test
Ensure the device has some network credentials configured, then hold SETUP button for ~10 seconds.
Example App
N/A
References
https://docs.particle.io/guide/getting-started/modes/photon/#wi-fi-network-reset
Completeness
Bugfix
[PR #1316]Fixes LED indication when network credentials are cleared by holding the SETUP button for >10 seconds.