Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Issue #1282.
Wire1
on Electron does not work correctly.Wire1
I2C testsSolution
Wire
andWire1
on Electron cannot be enabled simultaneously, since they share the same peripheralwiring/no_fixture
test added:WIRE_02_Wire_and_Wire1_cannot_be_enabled_simultaneously_on_Electron
Wire
orWire1
is enabled.Wire::reset()
implementation moved to HAL (HAL_I2C_Reset
)i2c_master_slave
andi2c_mcp23017
tests now acceptUSE_WIRE
make argument that specifies whichWire
interface should be used in tests (e.g.make PLATFORM=electron TEST=wiring/i2c_mcp23017 USE_WIRE=Wire1 clean all program-dfu
)Steps to Test
wiring/no_fixture
:WIRE_02_Wire_and_Wire1_cannot_be_enabled_simultaneously_on_Electron
i2c_mcp23017
i2c_master_slave/i2c_master
andi2c_master_slave/i2c_slave
Completeness
Bugfix
[PR #1302]
[Fixes #1282]
[Electron]
Wire1
was not working correctly.