Avoid division by zero when map() is called with incorrect parameters #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…; provide map() overload for double type
|
Thanks for the docs, @monkbroc! I wasn't sure if we're still committing them directly to the firmware repo or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1193 by adding a check into
map()function that ensures that incorrect parameters won't cause division by zero error. The PR also overloadsmap()to takedoublearguments.Doneness:
docs/prerelease)Bug fixes
[PR #1248][Fixes #1193]Fixes divide by zero on incorrect parameters ofmap()function.Enhancements
[PR #1248]Added an overload tomap()function that takesdoublearguments.