New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding logging here without { } was publishing safe mode unconditionally #1230

Merged

technobly merged 1 commit into develop from feature/fix-safe-mode

Jan 13, 2017

Member

technobly commented Jan 10, 2017 •

edited

Loading

Adding logging here without { } was publishing safe mode unconditionally

Doneness:

Contributor has signed CLA
Problem and Solution clearly stated
Code peer reviewed
API tests compiled
Run unit/integration/application tests on device (N/A)
Add documentation (N/A)
Add to CHANGELOG.md after merging (add links to docs and issues)

Bugfixes

[PR #1230] Safe Mode event was being published unconditionally


          adding logging here without { } was publishing safe mode unconditionally

81a2119

technobly added the bug label

technobly added this to the 0.6.1 milestone

technobly requested a review from avtolstoy

January 10, 2017 18:26

avtolstoy approved these changes

View reviewed changes

technobly merged commit 767e94e into develop

technobly deleted the feature/fix-safe-mode branch

January 13, 2017 18:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug