fix: remove emoji #393
Merged
fix: remove emoji #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for biseo-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SnowSuno
requested changes
Sep 24, 2023
package-lock.json
Outdated
There was a problem hiding this comment.
엇 혹시 npm install 로 패키지 설치하셨나요? 비서에서는 pnpm 쓰고있어서 npm 대신 pnpm 사용해야 해요!
이 파일은 지워주시면 될 것 같습니당
| @@ -1,7 +1,7 @@ | |||
| import React, { useCallback, useMemo } from "react"; | |||
| import { css } from "@emotion/react"; | |||
|
|
|||
| import { EmoticonIcon, SendIcon } from "@/assets"; | |||
| // import { EmoticonIcon, SendIcon } from "@/assets"; | |||
There was a problem hiding this comment.
코드 삭제는 어차피 기록에 남기 때문에 굳이 주석 처리하고 남겨두는 것보다는 아예 지워 주시면 될 것 같아요!
Suggested change
| // import { EmoticonIcon, SendIcon } from "@/assets"; |
|
|
||
| import { EmoticonIcon, SendIcon } from "@/assets"; | ||
| // import { EmoticonIcon, SendIcon } from "@/assets"; | ||
| import { SendIcon } from "@/assets"; // remove emoji |
There was a problem hiding this comment.
코드에 대해서 설명을 남기고 싶을 때는 코드 내에 주석으로 남기는 것보다 깃헙 PR 내에서 자신의 작업사항에 대해서도 댓글을 남길 수 있으니 그렇게 남겨주시면 될 것 같아요!
Suggested change
| import { SendIcon } from "@/assets"; // remove emoji | |
| import { SendIcon } from "@/assets"; |
| @@ -86,7 +86,7 @@ export const ChatInput: React.FC<Props> = ({ send }) => { | |||
| /> | |||
| <Divider dir="vertical" /> | |||
| </div> | |||
| <EmoticonIcon /> | |||
| {/* <EmoticonIcon /> */} | |||
There was a problem hiding this comment.
Suggested change
| {/* <EmoticonIcon /> */} |
withSang
previously approved these changes
Sep 24, 2023
| @@ -86,7 +86,7 @@ export const ChatInput: React.FC<Props> = ({ send }) => { | |||
| /> | |||
| <Divider dir="vertical" /> | |||
| </div> | |||
| <EmoticonIcon /> | |||
| {/* <EmoticonIcon /> */} | |||
There was a problem hiding this comment.
아래처럼 {/* TODO: Add EmoticonIcon */} 을 추가해주셔도 좋습니다!
babycroc
reviewed
Sep 24, 2023
SnowSuno
requested changes
Sep 25, 2023
package-lock.json
Outdated
There was a problem hiding this comment.
삭제한줄 알았는데 실수로 또 그냥 올렸네요 ㅜㅜ 다시push 했어용...
There was a problem hiding this comment.
이거 없애려면 git rm 커맨드 이용해야해요 그래야 깃허브에서도 지워질거같습니다.
| @@ -86,7 +85,7 @@ export const ChatInput: React.FC<Props> = ({ send }) => { | |||
| /> | |||
| <Divider dir="vertical" /> | |||
| </div> | |||
| <EmoticonIcon /> | |||
| {/* TODO: Add EmoticonIcon */} | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #232
일단 이모티콘 버튼 없애봤습니다...! 문제 있다면 알려주세요.