Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs :Expanded documentation coverage #78

Merged
merged 5 commits into from
Sep 10, 2023

Conversation

DeleMike
Copy link
Contributor

Added documentation for the compiler, component parser, and file-based router and updated the README to include Documentation links plus introducing a new section - "What's New?!"

Added documentation for the compiler, component parser, file-based router and updated the README to inlcude Documentation links plus a introducing a new section -  what's new?!
docs/file_based_router.md Outdated Show resolved Hide resolved
docs/file_based_router.md Outdated Show resolved Hide resolved
docs/component_parser.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/component_parser.md Outdated Show resolved Hide resolved
docs/compiler.md Outdated Show resolved Hide resolved
@sansyrox
Copy link
Member

Hey @DeleMike 👋

Thanks for the PR 😄 I have some suggestions.

Do let me know if you have any questions!

docs/compiler.md Outdated Show resolved Hide resolved
docs/compiler.md Outdated Show resolved Hide resolved
Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @DeleMike 😄

I have some minor suggestions

@DeleMike
Copy link
Contributor Author

DeleMike commented Sep 4, 2023

Hey @sansyrox, thanks for the feedback. I have made some changes to the PR.

Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work @DeleMike 🔥

@sansyrox sansyrox merged commit f6aeb35 into sparckles:main Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants