-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a way to specify the position of child components. #39
Comments
I would like to work on this issue |
In React, you can specify the position of children components! e.g.
Similarly, there is a concept of slots in svelte. However, in Starfyre, we add children at the end of the stack and have no explicit way of specifying the position of children. For this issue there are 2 steps involved
Do let me know if you require any more information from my end! |
Also, please go ahead @SuelenKarbivnychyy 😄 |
…ated,-Adressed-the-case-if-slot-is-not-specifyed-on-custom-componente-definition.): Developed a way of adding original name when the component is created by adding __pos_init__ method to the component class, this way we improve code maintainability. Adressed the case if slot is not specifyed on custom componente definition component.py parser.py BREAKING CHANGE: This closes the issue sparckles#39
delete white spaces, deleted extra inline comment, using is_slot_element property instead of "slot" as string. sparckles#39
deleted pos_init_ method and assign original_name to every instance of the class on diferent files. Deleted extra comments sparckles#39
Get the latest changes and solved merge conflicts sparckles#39
Fixed the text node order of slot components and implemented a approach to have the correct behavior when custom compoment is the root node in __innit__.fyre BREAKING CHANGE: sparckles#39
{children}
The text was updated successfully, but these errors were encountered: