Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

htmlmin task would remove disqus_thread #56

Closed
Cee opened this issue Oct 18, 2016 · 1 comment
Closed

htmlmin task would remove disqus_thread #56

Cee opened this issue Oct 18, 2016 · 1 comment
Assignees
@sparanoid
Labels
bug Something isn't working confirmed grunt

Comments

@Cee
Copy link

Cee commented Oct 18, 2016

No description provided.

@sparanoid
Copy link
Owner

sparanoid commented Oct 18, 2016 •
edited
Loading

htmlmin is set to removeEmptyElements: true for AMSF, for now there's a workaround you can add a space inside the element you'd like to keep, for example:

<div id="disqus_thread"> </div>

I'm also considering disabling removeEmptyElements in future release.

@sparanoid sparanoid self-assigned this Oct 18, 2016
@sparanoid sparanoid added bug Something isn't working grunt confirmed labels Oct 18, 2016
sparanoid added a commit that referenced this issue Oct 18, 2016
@sparanoid
feat(grunt): disable removeEmptyElements by default since it causes…
c541844 
… too much troble in the past, also props @Cee, should fix #56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sparanoid sparanoid

Labels
bug Something isn't working confirmed grunt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sparanoid @Cee