Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First draft of a maubot role #373

Closed
wants to merge 8 commits into from
Closed

Conversation

Cadair
Copy link
Contributor

@Cadair Cadair commented Feb 10, 2020

This adds https://github.com/maubot/maubot

I have done much of this blind and with copy paste, so I am sure there is a lot to improve!

@aaronraimist
Copy link
Contributor

@paulbdavis also has a maubot role here: https://github.com/dangersalad/matrix-docker-ansible-deploy which has been working for me

(separated on its own branch here just to make it easier to see the changes master...aaronraimist:maubot)

@Cadair
Copy link
Contributor Author

Cadair commented Feb 10, 2020

That looks a lot more complete than this one, can it get PRed over?

@aaronraimist
Copy link
Contributor

He said he is planning to after he PRs the bridges. The role works, I've been running it for a couple days. He said there was some changes he needed to make with the docker image so he'll need to make a PR with those to maubot.

@Cadair
Copy link
Contributor Author

Cadair commented Feb 10, 2020

Well I am very happy to close this in favour of that once it's open.

Comment on lines +9 to +11
with_items: []
#- 'matrix_user_uid'
#- 'matrix_user_gid'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In git is is a good practice to remove such code and later dig trough the history if you need it again.

Copy link
Contributor

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@Cadair Cadair closed this May 28, 2020
@Cadair Cadair mentioned this pull request Aug 5, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants