Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tls_hostname deprecation warning #1060

Closed
aaronraimist opened this issue May 18, 2021 · 3 comments
Closed

Fix tls_hostname deprecation warning #1060

aaronraimist opened this issue May 18, 2021 · 3 comments
Labels
suggestion This issue is a feature request

Comments

@aaronraimist
Copy link
Contributor

@spantaleev
Copy link
Owner

This is the error in question.

TASK [matrix-base : Ensure Matrix network is created in Docker] **********************************************************************************************************************************
[DEPRECATION WARNING]: The default value "localhost" for tls_hostname is deprecated and will be removed in community.docker 2.0.0. From then on, docker_host will be used to compute
tls_hostname. If you want to keep using "localhost", please set that value explicitly. This feature will be removed from community.docker in version 2.0.0. Deprecation warnings can be disabled
by setting deprecation_warnings=False in ansible.cfg.

Not sure if we should do anything about this.

We're not passing tls_hostname explicitly. Looks like this module will start defaulting to docker_host, which appears to default to unix://var/run/docker.sock. Such a new default value will probably also work for us.

@aaronraimist
Copy link
Contributor Author

Perhaps we could either set it explicitly to unix://var/run/docker.sock or localhost at least temporarily until that version is released

@spantaleev
Copy link
Owner

docker_host: unix://var/run/docker.sock doesn't help.

tls_hostname: unix://var/run/docker.sock does.

Still, it's somewhat silly having to specify tls_hostname while tls has a default value of false. We don't use TLS, supposedly. This seems to be an Ansible (collection) bug, which appears to have already been fixed here: ansible-collections/community.docker#143

I guess we need to wait a while and the deprecation message will disappear.

@luixxiul luixxiul added the suggestion This issue is a feature request label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion This issue is a feature request
Projects
None yet
Development

No branches or pull requests

3 participants