Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only emit tls_hostname deprecation warning if TLS is actually used #143

Merged
merged 2 commits into from
May 17, 2021

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Right now it is also emitted if TLS is not used to talk to Docker daemon.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/module_utils/common.py

@ssbarnea
Copy link
Member

@felixfontein I observed these really annoying warnings with molecule-docker driver and I failed to find any combination of arguments to give to docker modules that would avoid creating these warnings.

That is weird because I usually use a remove docker host using SSH, like DOCKER_HOST=ssh://[email protected] which is secure by definition and still not TLS related.

Note: disabling all Ansible warnings is no option, it would be a very irresponsible move.

@ssbarnea
Copy link
Member

I confirm that this fix address the issue for for those using ssh:// too.

@felixfontein felixfontein merged commit c201869 into ansible-collections:main May 17, 2021
@felixfontein felixfontein deleted the fix-deprecation branch May 17, 2021 11:24
@felixfontein
Copy link
Collaborator Author

@ssbarnea thanks for testing/reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants